[vlc-devel] [PATCH 1/4] aout: rename "stereo mode" to "output mode"

Jean-Baptiste Kempf jb at videolan.org
Mon Apr 2 13:38:36 CEST 2018

On Sat, 31 Mar 2018, at 08:24, RĂ©mi Denis-Courmont wrote:
> I did provide explanations what makes no sense and nobody explained how 
> it  would. I also provided references to the rationale for why stuff is 
> and needs to be like it is.

And don't give me the "trac and commit log" argument.
There are 10 of thousands of commits logs and trac comments.

> I do not appreciate false accusations in public and IIRC, this is a 
> violation of CoC. So plonk.

It is clearly not a CoC violation to ask for explanations.

So plonk also.

Seriously, there is absolutely no technical or UX arguments from you on this patch, except vague stuff from the past.

The patch is very reasonable, it just does a renaming of something that does already do more than stereo-mode (mono) and fulfills a very much requested feature, aka controlling the channels output, for a specific input.
And this is a constant demand from our users, since we removed the fake-devices mode from the menus.

If you don't give any good technical/UX argument, then this review is totally useless.

Jean-Baptiste Kempf -  President
+33 672 704 734

More information about the vlc-devel mailing list