[vlc-devel] [vlc-commits] macosx: don't expose input_item_HasErrorWhenReading to the end-user as this achieves misleading results at best

[David Fuhrmann]

Hi Felix,

Was there any further intention why you did not do this patch in vlc.git, but in vlc-3.0.git only?

If not, I would be in favor of forward porting that to vlc.git as well, unless / before we find a nicer solution.

BR. David


> Am 14.02.2018 um 17:54 schrieb Felix Paul Kühne <git at videolan.org>:
> 
> vlc/vlc-3.0 | branch: master | Felix Paul Kühne <felix at feepk.net> | Wed Feb 14 17:54:36 2018 +0100| [db04c76270c3f483fd911b91b6b003cf1bfedcfd] | committer: Felix Paul Kühne
> 
> macosx: don't expose input_item_HasErrorWhenReading to the end-user as this achieves misleading results at best
> 
>> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=db04c76270c3f483fd911b91b6b003cf1bfedcfd
> ---
> 
> modules/gui/macosx/VLCPLModel.m | 5 -----
> 1 file changed, 5 deletions(-)
> 
> diff --git a/modules/gui/macosx/VLCPLModel.m b/modules/gui/macosx/VLCPLModel.m
> index 379dbafd09..d1897f0dbd 100644
> --- a/modules/gui/macosx/VLCPLModel.m
> +++ b/modules/gui/macosx/VLCPLModel.m
> @@ -576,11 +576,6 @@ static int VolumeUpdated(vlc_object_t *p_this, const char *psz_var,
> 
>         o_value = [VLCByteCountFormatter stringFromByteCount:[attributes fileSize] countStyle:NSByteCountFormatterCountStyleDecimal];
> 
> -    } else if ([o_identifier isEqualToString:STATUS_COLUMN]) {
> -        if (input_item_HasErrorWhenReading(p_input)) {
> -            o_value = [[NSWorkspace sharedWorkspace] iconForFileType:NSFileTypeForHFSTypeCode(kAlertCautionIcon)];
> -            [o_value setSize: NSMakeSize(16,16)];
> -        }
>     }
> 
>     return o_value;
> 
> _______________________________________________
> vlc-commits mailing list
> vlc-commits at videolan.org
> https://mailman.videolan.org/listinfo/vlc-commits