[vlc-devel] [PATCH 1/4] es: move i_profile/i_level to audio and video format structs
ileoo at videolan.org
Tue Apr 3 11:55:40 CEST 2018
On Tue, Apr 03, 2018 at 12:39:52PM +0300, Rémi Denis-Courmont wrote:
> Le mardi 3 avril 2018, 12:26:29 EEST Ilkka Ollakka a écrit :
> > That is still part of the agreed Code of Conduct that we all have agreed
> > to follow and have been doing some time.
> Probably but that part is also only an advice or a conditional requirement,
> not a absolute requirement.
That is true.
> If you cannot criticize patches in public, you cannot do a honest code review.
> That is a well documented paradox, and one of the serious challenges of open-
> source in certain cultures with an emphasis on face keeping.
Giving critique in public is skill of it's own. And I agree that it's
somewhat different than just reviewing if code is correct or not. There
is also the setup problem of reviewer being judge instead of giving
suggestions or toughts as peer. And that also raises the bar on people
to review code in my opinion.
> Actually it also says not to insult or troll people - inconditionally. Yet, a
> lot of key people have done exactly that in the past few years, especially on
> IRC, without any actions.
It's true, trolling is part of the culture in some aspect, but it also
requires quite a lot of skill not to cross the border and turn into
insulting, which it does in most cases.
But I think we as asso have took action on all CoC complaints that have
arrived to the list. I think it's reasonable to expect that, but not
to expect pre-emptive monitoring all the time?
> I don't necessarily condone it, but that's the reality.
That is true, we don't really have means to enfore it in all the time
and all the places. Hope is on the people to have some self-judgement
and self-knowledge to act and take others, who share the same space-time
junction, into consideration.
More information about the vlc-devel