[vlc-devel] [PATCH 1/4] aout: rename "stereo mode" to "output mode"

[Rémi Denis-Courmont]

Le torstaina 5. huhtikuuta 2018, 19.07.57 EEST Thomas Guillem a écrit :
> On Thu, Apr 5, 2018, at 18:05, Rémi Denis-Courmont wrote:
> > Le torstaina 5. huhtikuuta 2018, 19.02.48 EEST Thomas Guillem a écrit :
> > > On Mon, Apr 2, 2018, at 20:35, Rémi Denis-Courmont wrote:
> > > > Breaking the stereo mode variable to introduce a surround-related
> > > > feature makes no sense without rationale why the old features are no
> > > > longer relevant. I have not seen any such explanations, and I don't
> > > > think the community would agree to drop dual-mono support, etc.
> > > 
> > > Do you want me to forward the "--stereo-mode" option to the
> > > "--aout-mode" as backward compatibility ?
> > 
> > No. I want to keep stuff as it is.
> > 
> > Renaming a variable just for the sake of renaming a variable, no thanks.
> 
> And what about the strings/qt menu ? Can we use "Output mode" ? (since we
> want to add options that are not stereo related).

Considering the large number of complaints about nonexistent alleged Audio 
channels menu changes, I would strongly advise against changing the visible 
name.

I don't personally care much though.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/