[vlc-devel] [PATCH] vout: fix fullscreen race condition

Romain Vimont rom1v at videolabs.io
Tue Apr 17 16:25:28 CEST 2018

On Tue, Apr 17, 2018 at 04:12:49PM +0300, RĂ©mi Denis-Courmont wrote:
> Nack. This is a Qt bug. Don't clobber the full screen flag(s) and interfere with other interfaces.

Thank you for your review.

I think the root cause of the bug is not related to Qt: in
modules/control/hotkeys.c:PutAction(), case ACTIONID_TOGGLE_FULLSCREEN
changes only the playlist variable if p_vout is NULL, e.g. during the
vout creation. In that case, once the vout is created, the playlist
"fullscreen" variable may be different from the vout "fullscreen"
variable, even if Qt is not involved at all.

More information about the vlc-devel mailing list