[vlc-devel] [PATCH] vout: fix fullscreen race condition

[Rémi Denis-Courmont]

Le tiistaina 17. huhtikuuta 2018, 17.25.28 EEST Romain Vimont a écrit :
> On Tue, Apr 17, 2018 at 04:12:49PM +0300, Rémi Denis-Courmont wrote:
> > Nack. This is a Qt bug. Don't clobber the full screen flag(s) and
> > interfere with other interfaces.
> Thank you for your review.
> 
> I think the root cause of the bug is not related to Qt: in
> modules/control/hotkeys.c:PutAction(), case ACTIONID_TOGGLE_FULLSCREEN
> changes only the playlist variable if p_vout is NULL, e.g. during the
> vout creation. In that case, once the vout is created, the playlist
> "fullscreen" variable may be different from the vout "fullscreen"
> variable, even if Qt is not involved at all.

How is that a bug? Obviously, there has to be a point when the switch happens; 
there is nothing hotkeys can do about that. User interaction are always 
fundamentally racy, if only because humans have a reaction latency.

Meanwhile, Qt shows a fullscreen video window, and, at the same time, does not 
show the FSC. That is totally a bug within Qt GUI.

-- 
レミ・デニ-クールモン
http://www.remlab.net/