[vlc-devel] [vlc-commits] videotoolbox: always abort in case of BadDataErr

[Rémi Denis-Courmont]

Le vendredi 20 avril 2018, 19:52:10 EEST Thomas Guillem a écrit :
> > This sort of makes sense for offline records. But fior live streams, bad
> > data could very well be some transient problem.
> 
> Yes, unfortunately this commit disables VT playback with some of my dumped
> ts samples. But there are more and more BadData coming from offline files.
> I prefer the safe way.

On the one hand, if disabling VT is safe, then "the safe way" is to disable 
hardware decoding altogether for affected codecs. It avoids glitches in this 
case.

On the other hand, if disabling VT is unsafe because software decoding is too 
slow, then this commit is not safe at all. In that case, this commit actually 
would break playback, not fix it.

-- 
Rémi Denis-Courmont