[vlc-devel] [PATCH] Enable/Disable/Auto deinterlace functions for libvlc

Luís Fernandes zipleen at gmail.com
Sat Apr 28 20:13:06 CEST 2018


Hi all,

I’ve reworked the patch to change the method signature, and thus break compatibility with 3.0.
I’ve added a \version annotation to the .h of the function, but I have no idea if I need to do anything else to signal that this is for libvlc4. 
Please advice on what I need to add more for the patch to be accepted.

Some notes on the patch:
- I had to add "auto" because the default deinterlace-mode for VLCKit is normally "auto", so without it the mode would never get triggered
- default mode is "auto" (-1) - which seems to be the default mode for vlc as well

Regards,
Luís

-------------- next part --------------
A non-text attachment was scrubbed...
Name: vlckit_auto_deinterlacer_4.patch
Type: application/octet-stream
Size: 3856 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180428/249235e1/attachment.obj>
-------------- next part --------------


> On 22 Apr 2018, at 11:13, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> 
> Hello,
> 
> On Sun, 22 Apr 2018, at 09:37, Rémi Denis-Courmont wrote:
>> IMO, an API clean-up and thus an ABI break is well overdue in general, and 
>> with that, I'd do 1. But that's just my own personal opinion.
> 
> Yes. Break API and ABI for 4.0. libvlc6. Go ahead.
> 
> But if anyone breaks ABI for 3.0, I'll break his neck. (in a soft fashion) :D
> 
> -- 
> Jean-Baptiste Kempf -  President
> +33 672 704 734
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel



More information about the vlc-devel mailing list