[vlc-devel] [PATCH] Enable/Disable/Auto deinterlace functions for libvlc

[Steve Lhomme]

Please post your patches inline, it's easier to comment


+    if (deinterlace < -1 || deinterlace > 1)
+        deinterlace = -1;
To make it more clear what you're doing maybe check if the value is 
neither 0 nor 1.


+        module_config_t *config = config_FindConfig("deinterlace-mode");
This should be var_GetString


+     && strcmp (psz_mode, "auto"))
It seems that should go in another patch before this one.


-        var_SetInteger (p_mi, "deinterlace", 1);
+        var_SetInteger (p_mi, "deinterlace", deinterlace);
      }
      else
-        var_SetInteger (p_mi, "deinterlace", 0);
+        var_SetInteger (p_mi, "deinterlace", deinterlace);

In both cases of the else you do the same call. So don't do it in the else.


Le 28/04/2018 à 20:13, Luís Fernandes a écrit :
> Hi all,
>
> I’ve reworked the patch to change the method signature, and thus break compatibility with 3.0.
> I’ve added a \version annotation to the .h of the function, but I have no idea if I need to do anything else to signal that this is for libvlc4.
> Please advice on what I need to add more for the patch to be accepted.
>
> Some notes on the patch:
> - I had to add "auto" because the default deinterlace-mode for VLCKit is normally "auto", so without it the mode would never get triggered
> - default mode is "auto" (-1) - which seems to be the default mode for vlc as well
>
> Regards,
> Luís
>
>
>
>
>> On 22 Apr 2018, at 11:13, Jean-Baptiste Kempf <jb at videolan.org> wrote:
>>
>> Hello,
>>
>> On Sun, 22 Apr 2018, at 09:37, Rémi Denis-Courmont wrote:
>>> IMO, an API clean-up and thus an ABI break is well overdue in general, and
>>> with that, I'd do 1. But that's just my own personal opinion.
>> Yes. Break API and ABI for 4.0. libvlc6. Go ahead.
>>
>> But if anyone breaks ABI for 3.0, I'll break his neck. (in a soft fashion) :D
>>
>> -- 
>> Jean-Baptiste Kempf -  President
>> +33 672 704 734
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180430/8dff4db4/attachment.html>