[vlc-devel] [PATCH] es_out: merge es->i_id with es->fmt.i_id

Thomas Guillem thomas at gllm.fr
Fri Aug 17 13:52:21 CEST 2018

I would prefer to keep using the integer i_id as a unique es track identifier since it's very simple to handle.

The main input or slaves goes through the same es_out instance that keep the list of all ES tracks, so this should be a simple issue to fix.  

So, either we don't expose fmt.i_id from the demux and always increment an unique id (like it's already done if fmt.i_id < 0). But then, this break es track selection (when passing parameters per es).

Of we mix both solution: if the demux fmt.i_id is not automatic (not -1), we iterate through our es tracks to make sure it is unique. If it's not unique: ERROR, or use the incremented unique value.
On Fri, Aug 17, 2018, at 13:38, Francois Cartegnie wrote:
> Le 17/08/2018 à 13:22, Rémi Denis-Courmont a écrit :
> > FMT ID is useful metadata in some cases. But ES ID should not even exist, as we cannot guarantee uniqueness in case of slave demuxers.
> > 
> Then every user would need to know or guess stream creation order to
> pass parameters per es.
> Unfair dice or crystal ball also required to remap es in muxers.
> -- 
> Francois Cartegnie
> VideoLAN - VLC Developer
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list