[vlc-devel] [PATCH] es_out: merge es->i_id with es->fmt.i_id

Francois Cartegnie fcvlcdev at free.fr
Fri Aug 24 16:35:28 CEST 2018

Le 19/08/2018 à 10:16, Thomas Guillem a écrit :
> I agree about keeping fmt.id for TS ES and using an unique ID for libvlc
> or the new input manager.
> Using a void* can be racy when deleting and creating an ES (the es can
> use the same pointer).
> An integer overflow is very unlikely to happen when creating an ES (and
> we can still check the overflw and fail if it happens).
> Do you still prefer using void* ?

Users can refer to ES by creation order (index, so es_out unique ID) for
sub-track= or video-track= when there's no fmt.id.
We'll still need a unique integer value on each ES then :/

Considering track selection not only at es_out level but also in sout
modules, it would also require to store that index on fmt (or pass along
with with sout_input Add calls).

Francois Cartegnie
VideoLAN - VLC Developer

More information about the vlc-devel mailing list