[vlc-devel] [PATCH] es_out: merge es->i_id with es->fmt.i_id

[Rémi Denis-Courmont]

Le perjantaina 24. elokuuta 2018, 17.35.28 EEST Francois Cartegnie a écrit :
> Le 19/08/2018 à 10:16, Thomas Guillem a écrit :
> > I agree about keeping fmt.id for TS ES and using an unique ID for libvlc
> > or the new input manager.
> > Using a void* can be racy when deleting and creating an ES (the es can
> > use the same pointer).
> > An integer overflow is very unlikely to happen when creating an ES (and
> > we can still check the overflw and fail if it happens).
> > Do you still prefer using void* ?
> 
> Users can refer to ES by creation order (index, so es_out unique ID) for
> sub-track= or video-track= when there's no fmt.id.
> We'll still need a unique integer value on each ES then :/

AFAICT, it's up to the demuxer to provide stable ES IDs, like TS does.
The ES output cannot do that without demuxer cooperation.

-- 
Rémi Denis-Courmont
http://www.remlab.net/