[vlc-devel] [vlc-commits] plugin cache: Windows doesn't like relative pathes in LoadLibraryEx()

[Rémi Denis-Courmont]

This looks like a totally out of place ifdef kludge. And it seems trivial to avoid it by solving the problem in the existing Win32 support backend.

And it probably breaks cache assumptions.

Le 13 décembre 2018 14:11:02 GMT+02:00, Steve Lhomme <git at videolan.org> a écrit :
>vlc | branch: master | Steve Lhomme <robux4 at videolabs.io> | Fri Sep 30
>09:49:19 2016 +0200| [3edd48f2ecac2471af0f00941b9e52948fca79e5] |
>committer: Steve Lhomme
>
>plugin cache: Windows doesn't like relative pathes in LoadLibraryEx()
>
>Fixes "vlc-cache-gen ../modules" on Windows and general VLC_PLUGIN_PATH
>usage.
>
>>
>http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=3edd48f2ecac2471af0f00941b9e52948fca79e5
>---
>
> src/modules/bank.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/src/modules/bank.c b/src/modules/bank.c
>index 331fdc40ca..a67c338a8b 100644
>--- a/src/modules/bank.c
>+++ b/src/modules/bank.c
>@@ -474,7 +474,11 @@ static void AllocateAllPlugins (vlc_object_t
>*p_this)
>     if( paths == NULL )
>         return;
> 
>+#ifdef _WIN32
>+    paths = realpath( paths, NULL );
>+#else
>     paths = strdup( paths ); /* don't harm the environment ! :) */
>+#endif
>     if( unlikely(paths == NULL) )
>         return;
> 
>
>_______________________________________________
>vlc-commits mailing list
>vlc-commits at videolan.org
>https://mailman.videolan.org/listinfo/vlc-commits

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20181213/bd6bd11f/attachment.html>