[vlc-devel] [vlc-commits] service_discovery: lock playlist_ServicesDiscoveryKillAll()

Rémi Denis-Courmont remi at remlab.net
Mon Feb 12 22:51:01 CET 2018


Care to explain what race this protects against?

playlist_ServicesDiscoveryKillAll() gets called by playlist_Destroy(). At that 
point, all interfaces are already shut down. So I don't exactly see by whom 
playlist_ServicesDiscoveryRemove() can be called by then... ?

Besides, if playlist_ServicesDiscoveryRemove() could actually get called, then 
how do you prevent playlist_ServicesDiscoveryAdd() and ensuing deadlocks?


More information about the vlc-devel mailing list