[vlc-devel] [PATCH 1/1] arm: fix assembling with llvm's integrated assembler for ios

[Carola Nitz]

> On Feb 7, 2018, at 8:12 PM, Martin Storsjö <martin at martin.st> wrote:
> 
> On Wed, 7 Feb 2018, Rémi Denis-Courmont wrote:
> 
>> Le tiistaina 6. helmikuuta 2018, 23.54.55 EET Martin Storsjö a écrit :
>>> On Tue, 6 Feb 2018, Janne Grunau wrote:
>>> > ---
>>> > modules/arm_neon/amplify.S                     |  8 ++++--
>>> > modules/arm_neon/asm.S                         | 31 +++++++++++++++++++++
>>> > modules/arm_neon/deinterleave_chroma.S         | 10 ++++---
>>> > modules/arm_neon/i420_rgb.S                    | 10 ++++---
>>> > modules/arm_neon/i420_rv16.S                   | 10 ++++---
>>> > modules/arm_neon/i420_yuyv.S                   | 14 +++++-----
>>> > modules/arm_neon/i422_yuyv.S                   | 14 +++++-----
>>> > modules/arm_neon/nv12_rgb.S                    | 10 ++++---
>>> > modules/arm_neon/nv21_rgb.S                    | 10 ++++---
>>> > modules/arm_neon/simple_channel_mixer.S        | 38
>>> > +++++++++----------------- modules/arm_neon/yuyv_i422.S > | 14 +++++-----
>>> > modules/video_filter/deinterlace/merge_arm.S   | 20 ++++++--------
>>> > modules/video_filter/deinterlace/merge_arm64.S | 10 +++----
>>> > 13 files changed, 112 insertions(+), 87 deletions(-)
>>> > create mode 100644 modules/arm_neon/asm.S
>>> > > diff --git a/modules/arm_neon/amplify.S b/modules/arm_neon/amplify.S
>>> > index 5938118378..711a3ea4f7 100644
>>> > --- a/modules/arm_neon/amplify.S
>>> > +++ b/modules/arm_neon/amplify.S
>>> > @@ -18,18 +18,20 @@
>>> > >  @ Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
>>> >  @************************************************************************
>>> >  ****/> > +#include "asm.S"
>>> > +
>>> > > 	.syntax	unified
>>> > 	.arm
>>> > > +#ifndef __APPLE__
>>> > > 	.fpu	neon
>>> > > +#endif
>>> > > 	.text
>>> Or maybe go for #ifdef __ELF__,
>> 
>> No, .fpu and .arch directives have nothing to do with the output executable format.
> 
> That's correct, but despite that, those directives are unavailable when targeting both macOS and Windows.
> 
> If you prefer #if !defined(__APPLE__) && !defined(_WIN32), I can live with that as well.

I didn’t see this patch getting pushed into vlc yet. Is this still work in progress ?
I just want to make sure Remi and Jannes work at Fosdem is not in vain :)

- Caro
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180217/98dd1dac/attachment.html>