[vlc-devel] [PATCH v2 1/1] arm: make the assembler functions compatible with non ELF/gas platforms
martin at martin.st
Mon Feb 19 09:50:09 CET 2018
On Mon, 19 Feb 2018, Janne Grunau wrote:
> On 2018-02-18 21:17:17 +0200, Martin Storsjö wrote:
>> On Sat, 17 Feb 2018, Carola Nitz via vlc-devel wrote:
>> > I didn’t see this patch getting pushed into vlc yet. Is this still work
>> > in progress ? I just want to make sure Remi and Jannes work at Fosdem is
>> > not in vain :)
>> To make it clear, I'm at least awaiting (from Janne) either a new patch or a
>> push with the ifdef changed into "#if !defined(__APPLE__) &&
>> !defined(_WIN32)" (or #ifdef __ELF__, although Rémi objected to that), ...
> Don't expect a push from me, I do not have commit rights AFAIK. I didn't
> tought adding the _WIN32 defines was expected from since I have no test
> setup for that.
Ah, sorry for being unclear - and thanks to Carola for getting things back
> Below is a patch which should handle ios and arm windows nevertheless. I
> added the two defines HAVE_AS_FPU_DIRECTIVE / HAVE_AS_ARCH_DIRECTIVE
> which limits the logic to a single place in asm.S and would allow moving
> the check to configure when autotools gains the capability to check the
Thanks, this part looks nice to me.
> It also applies the symbol prefix for win32.
Actually, win32 doesn't use any symbol prefix on arm/aarch64 - it doesn't
on x86_64 either, on only i386.
I can push the patch with that adjusted, if Rémi is ok with it otherwise.
More information about the vlc-devel