[vlc-devel] [RFC 1/7] subpictures: support rendering subpictures in display dimensions

[Rémi Denis-Courmont]

Le maanantaina 19. helmikuuta 2018, 12.43.04 EET Salah-Eddin Shaban a écrit :
> ---
>  include/vlc_spu.h                    |  3 +-
>  include/vlc_subpicture.h             | 13 ++++++++
>  include/vlc_vout_display.h           |  1 +
>  modules/stream_out/transcode/video.c |  2 +-
>  src/misc/subpicture.c                | 12 ++++++++
>  src/video_output/video_output.c      | 26 +++++++++++-----
>  src/video_output/vout_subpictures.c  | 59
> +++++++++++++++++++++++++----------- 7 files changed, 89 insertions(+), 27
> deletions(-)
> 
> diff --git a/include/vlc_spu.h b/include/vlc_spu.h
> index dc8ea90fa6..496349f3dd 100644
> --- a/include/vlc_spu.h
> +++ b/include/vlc_spu.h
> @@ -68,12 +68,13 @@ VLC_API void spu_PutSubpicture( spu_t *, subpicture_t *
> ); * subtitles visibles at the requested date.
>   *
>   * \param p_chroma_list is a list of supported chroma for the output (can
> be NULL)
> + * \param p_fmt_display is the format of the display. If
> identical to p_fmt_dst, subpictures will be rendered inside the video area.

I don't know what the video format of the display means. What is the display? 
How do you determine each and every video format members for whatever the 
display us?

Also I doubt that wording style will read well in the actual Doxygen output.

> * \param p_fmt_dst is the format of the picture on which the return
> subpicture will be rendered. * \param p_fmt_src is the format of the
> original(source) video.
>   *
>   * The returned value if non NULL must be released by subpicture_Delete().
>   */
> -VLC_API subpicture_t * spu_Render( spu_t *, const vlc_fourcc_t
> *p_chroma_list, const video_format_t *p_fmt_dst, const video_format_t
> *p_fmt_src, mtime_t render_subtitle_date, mtime_t render_osd_date, bool
> ignore_osd ); +VLC_API subpicture_t * spu_Render( spu_t *, const
> vlc_fourcc_t *p_chroma_list, const video_format_t *p_fmt_display, const
> video_format_t *p_fmt_dst, const video_format_t *p_fmt_src, mtime_t
> render_subtitle_date, mtime_t render_osd_date, bool ignore_osd );
> 
>  /**
>   * It registers a new SPU channel.
> diff --git a/include/vlc_subpicture.h b/include/vlc_subpicture.h
> index b9de52c049..76d1601073 100644

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/