[vlc-devel] [RFC 1/7] subpictures: support rendering subpictures in display dimensions

[Salah-Eddin Shaban]

On Mon, Feb 19, 2018 at 6:59 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le maanantaina 19. helmikuuta 2018, 12.43.04 EET Salah-Eddin Shaban a écrit :
>> ---
>>  include/vlc_spu.h                    |  3 +-
>>  include/vlc_subpicture.h             | 13 ++++++++
>>  include/vlc_vout_display.h           |  1 +
>>  modules/stream_out/transcode/video.c |  2 +-
>>  src/misc/subpicture.c                | 12 ++++++++
>>  src/video_output/video_output.c      | 26 +++++++++++-----
>>  src/video_output/vout_subpictures.c  | 59
>> +++++++++++++++++++++++++----------- 7 files changed, 89 insertions(+), 27
>> deletions(-)
>>
>> diff --git a/include/vlc_spu.h b/include/vlc_spu.h
>> index dc8ea90fa6..496349f3dd 100644
>> --- a/include/vlc_spu.h
>> +++ b/include/vlc_spu.h
>> @@ -68,12 +68,13 @@ VLC_API void spu_PutSubpicture( spu_t *, subpicture_t *
>> ); * subtitles visibles at the requested date.
>>   *
>>   * \param p_chroma_list is a list of supported chroma for the output (can
>> be NULL)
>> + * \param p_fmt_display is the format of the display. If
>> identical to p_fmt_dst, subpictures will be rendered inside the video area.
>
> I don't know what the video format of the display means. What is the display?
> How do you determine each and every video format members for whatever the
> display us?
>
> Also I doubt that wording style will read well in the actual Doxygen output.
>

This isn't final. In one of the comments I mentioned that --align
should be taken into account instead of assuming the video is centered
horizontally and vertically within its window. This placement is
currently performed by vout_display_PlacePicture which requires a
vout_display_cfg_t. We can't use something like that in spu_Render
since it's also called from stream_out.

Some refactoring might be necessary here.