[vlc-devel] [PATCH 2/2] arm: Allow building assembly in thumb mode

[Martin Storsjö]

On Wed, 21 Feb 2018, Janne Grunau wrote:

> On 2018-02-21 14:20:35 +0200, Martin Storsjö wrote:
>> Windows on arm is thumb2 only.
>> 
>> Add the necessary "it" instructions before conditionally executed
>> instructions (which doesn't emit any extra instructions when not
>> building in thumb mode). The number of "it" instructions could
>> be reduced in some places by reordering the instructions, but keeping
>> them as they were originally to avoid any impact on existing
>> targets.
>> 
>> Add #ifndef _WIN32 around a few ".arm" directives, since we shouldn't
>> force the assembler to arm mode in this target.
>
> wouldn't it make more sense to remove them and let the assembler use its 
> defaults or its command line options?

That's also just as ok with me. Rémi?

(In all cases I know of, except when targeting windows, the 
assembler starts out in arm mode even if the C compiler defaults to 
thumb, so it shouldn't be any functional change amyway.)

// Martin