[vlc-devel] [PATCH 2/2] arm: Allow building assembly in thumb mode

[Rémi Denis-Courmont]

Le keskiviikkona 21. helmikuuta 2018, 19.30.09 EET Janne Grunau a écrit :
> On 2018-02-21 14:20:35 +0200, Martin Storsjö wrote:
> > Windows on arm is thumb2 only.
> > 
> > Add the necessary "it" instructions before conditionally executed
> > instructions (which doesn't emit any extra instructions when not
> > building in thumb mode). The number of "it" instructions could
> > be reduced in some places by reordering the instructions, but keeping
> > them as they were originally to avoid any impact on existing
> > targets.
> > 
> > Add #ifndef _WIN32 around a few ".arm" directives, since we shouldn't
> > force the assembler to arm mode in this target.
> 
> wouldn't it make more sense to remove them and let the assembler use its
> defaults or its command line options?

Yeah, I guess. The directives were only there because Thumb was not supported.

Though the same discussion point can be made for the FPU and architecture 
directives *cough* *cough*.

> The thumb-ification itself and the configure patch look ok to me.

No clue - not familiar with Thumb syntax.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/