[vlc-devel] [vlc-commits] macosx: Display icons depending on renderer capabilities

[David Fuhrmann]

> Am 23.02.2018 um 13:26 schrieb Marvin Scholz <git at videolan.org>:
> 
> vlc | branch: master | Marvin Scholz <epirat07 at gmail.com> | Fri Feb 23 13:17:19 2018 +0100| [58c708a3afb6883837483eaa8cdfc7fb0d0b2d20] | committer: Marvin Scholz
> 
> macosx: Display icons depending on renderer capabilities
> 
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=58c708a3afb6883837483eaa8cdfc7fb0d0b2d20
> ---
> 
> modules/gui/macosx/VLCRendererMenuController.m | 4 ++++
> 1 file changed, 4 insertions(+)
> 
> diff --git a/modules/gui/macosx/VLCRendererMenuController.m b/modules/gui/macosx/VLCRendererMenuController.m
> index 2650651017..725275bf81 100644
> --- a/modules/gui/macosx/VLCRendererMenuController.m
> +++ b/modules/gui/macosx/VLCRendererMenuController.m
> @@ -111,6 +111,10 @@
>     NSMenuItem *menuItem = [[NSMenuItem alloc] initWithTitle:item.name
>                                                       action:@selector(selectRenderer:)
>                                                keyEquivalent:@""];
> +    if (item.capabilityFlags & VLC_RENDERER_CAN_VIDEO)
> +        [menuItem setImage:[NSImage imageNamed:@"sidebar-movie"]];
> +    else
> +        [menuItem setImage:[NSImage imageNamed:@"sidebar-music"]];
>     [menuItem setTarget:self];

Hi Marvin,

Do you really want to set icons in the main menu for macOS? AFAIK it is really uncommon to have icons at all, there…

BR. David