[vlc-devel] vlc-devel Digest, Vol 129, Issue 25

[Kamil Rytarowski]

On 23.02.2018 13:09, Kamil Rytarowski wrote:
> On 23.02.2018 12:00, vlc-devel-request at videolan.org wrote:
>> Hello,
>>
>> This looks overkill and possibly inconsistent. I don't think it makes sense to separately check freelocale, newlocale and locale_t, and doubt that the patch would handle such mismatch anyway.
>>
> 
> Please elaborate the inconsistency.
> 
> All the locale features in the fixup header are supported except
> uselocale(). Having it a dummy code as a fallback does the trick.
> 
>> Also as Hugo noted there should be no need to test locale.h and setlocale.
>>
>> In fact, I don't really see the point. What good are newlocale and freelocale without uselocale?
> 
> 
> The point is to make VLC buildable on NetBSD, one step closer to this state.
> 
> Leaving as it is causes fatal build errors of conflicts with system
> headers in <locale.h>.
> 

I've noted that a patch landed vlc-3.0:

configure: test for newlocale() separate from uselocale()

Thank you for this, I will follow up with next ones!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 850 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180223/1aa47078/attachment.sig>