[vlc-devel] [vlc-commits] mmdevice: skip if volume reset is enabled for now

[Thomas Guillem]

On Mon, Feb 26, 2018, at 23:25, Rémi Denis-Courmont wrote:
> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue Feb 
> 27 00:18:26 2018 +0200| [6bbc6b6cb191f1a4dd29bd059c90e9cbaf0edb16] | 
> committer: Rémi Denis-Courmont
> 
> mmdevice: skip if volume reset is enabled for now
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=6bbc6b6cb191f1a4dd29bd059c90e9cbaf0edb16
> ---
> 
>  modules/audio_output/mmdevice.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/modules/audio_output/mmdevice.c b/modules/audio_output/mmdevice.c
> index 731474848b..1943ad3767 100644
> --- a/modules/audio_output/mmdevice.c
> +++ b/modules/audio_output/mmdevice.c
> @@ -1201,6 +1201,9 @@ static void Stop(audio_output_t *aout)
>  
>  static int Open(vlc_object_t *obj)
>  {
> +    if (!var_InheritBool(obj, "volume-save"))
> +        return VLC_EGENERIC;
> +

Hello,

I strongly disagree with this commit.

mmdevice is a great module, we should all focus our debug efforts on it, and prevent users using old aout modules (or only if they have to (old windows for example)).

>      audio_output_t *aout = (audio_output_t *)obj;
>  
>      aout_sys_t *sys = malloc(sizeof (*sys));
> 
> _______________________________________________
> vlc-commits mailing list
> vlc-commits at videolan.org
> https://mailman.videolan.org/listinfo/vlc-commits