[vlc-devel] [vlc-commits] mmdevice: skip if volume reset is enabled for now

[Rémi Denis-Courmont]

Le 27 février 2018 14:30:26 GMT+02:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>
>On Mon, Feb 26, 2018, at 23:25, Rémi Denis-Courmont wrote:
>> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue
>Feb 
>> 27 00:18:26 2018 +0200| [6bbc6b6cb191f1a4dd29bd059c90e9cbaf0edb16] | 
>> committer: Rémi Denis-Courmont
>> 
>> mmdevice: skip if volume reset is enabled for now
>> 
>> >
>http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=6bbc6b6cb191f1a4dd29bd059c90e9cbaf0edb16
>> ---
>> 
>>  modules/audio_output/mmdevice.c | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/modules/audio_output/mmdevice.c
>b/modules/audio_output/mmdevice.c
>> index 731474848b..1943ad3767 100644
>> --- a/modules/audio_output/mmdevice.c
>> +++ b/modules/audio_output/mmdevice.c
>> @@ -1201,6 +1201,9 @@ static void Stop(audio_output_t *aout)
>>  
>>  static int Open(vlc_object_t *obj)
>>  {
>> +    if (!var_InheritBool(obj, "volume-save"))
>> +        return VLC_EGENERIC;
>> +
>
>Hello,
>
>I strongly disagree with this commit.
>
>mmdevice is a great module, we should all focus our debug efforts on
>it, and prevent users using old aout modules (or only if they have to
>(old windows for example)).
>
>>      audio_output_t *aout = (audio_output_t *)obj;
>>  
>>      aout_sys_t *sys = malloc(sizeof (*sys));
>> 
>> _______________________________________________
>> vlc-commits mailing list
>> vlc-commits at videolan.org
>> https://mailman.videolan.org/listinfo/vlc-commits
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

It is a fact that the current implementation of this module, and all previous versions of it, do not support --no-volume-save. This two-liner is just acknowledging the current factual state of the matter. It is *not* an opinion on the value and subjective quality, or lack thereof, of the module. (I do agree that it is better than legacy outputs, but that is a different matter.)

I don't understand the concept of disagreeing with facts.
-- 
Remi Denis-Courmont