[vlc-devel] [PATCH v2 01/10] core: add atomic refcounter helper

[Rémi Denis-Courmont]

There was a protection and you removed it. By definition, we can obviously not have more uintptr_max in-memory refs.

Now how does that thinking work with uint_max??

Le 2 juillet 2018 18:36:34 GMT+03:00, Romain Vimont <rom1v at videolabs.io> a écrit :
>On Mon, Jul 02, 2018 at 06:25:57PM +0300, Rémi Denis-Courmont wrote:
>> 1) This creates obvious overflow.
>
>There was no protection against refcount overflow before. This helper
>does not add a protection against refcount overflow.
>
>It seems to me that usages of atomic_uintptr_t for refcounters were
>just
>an inconsistency, not justified by atomic_uint being not large enough.
>And if it were the case, atomic_uintptr_t is not appropriate.
>
>> 
>> 2) So this won't work for e.g. picture_t.
>
>Patch 3 use the refcounter for picture_priv_t. What's the problem?
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180702/83740e4d/attachment.html>