[vlc-devel] [PATCH v2 01/10] core: add atomic refcounter helper

Romain Vimont rom1v at videolabs.io
Mon Jul 2 17:53:17 CEST 2018


On Mon, Jul 02, 2018 at 06:43:19PM +0300, RĂ©mi Denis-Courmont wrote:
> There was a protection and you removed it. By definition, we can obviously not have more uintptr_max in-memory refs.

There was no "protection", the type was just wider. But again, it seems
to me that this choice was arbitrary and inconsistent: there was no good
reason to use atomic_uintptr_t at some places and atomic_uint at some
others.

If there was a good reason, please tell me (this is the purpose of
reviews), so we just won't use vlc_atomic_rc_t for these 2 specific
cases.


More information about the vlc-devel mailing list