[vlc-devel] [PATCH] text_style: fix overflow in vlc_html_color

Salah-Eddin Shaban salah at videolan.org
Wed Jul 4 11:06:46 CEST 2018


On Wed, Jul 4, 2018 at 9:49 AM, RĂ©mi Denis-Courmont <remi at remlab.net> wrote:
> FWIW, strtoul() can exceed 32bits.
>

The switch statement just after strtoul() verifies that ( psz_end -
psz_hex ) is equal to 6 or 8. Otherwise it's not a valid color value
and will be ignored anyway.
The overflow was affecting valid 32-bit color values.

> Also nit in description.
>

What about the description?


More information about the vlc-devel mailing list