[vlc-devel] [PATCH] text_style: fix overflow in vlc_html_color

[Salah-Eddin Shaban]

On Wed, Jul 4, 2018 at 1:04 PM, Steve Lhomme <robux4 at ycbcr.xyz> wrote:
> On 2018-07-04 11:06, Salah-Eddin Shaban wrote:
>>
>> On Wed, Jul 4, 2018 at 9:49 AM, Rémi Denis-Courmont <remi at remlab.net>
>> wrote:
>>>
>>> FWIW, strtoul() can exceed 32bits.
>>>
>> The switch statement just after strtoul() verifies that ( psz_end -
>> psz_hex ) is equal to 6 or 8. Otherwise it's not a valid color value
>> and will be ignored anyway.
>> The overflow was affecting valid 32-bit color values.
>>
>>> Also nit in description.
>>>
>> What about the description?
>
>
> nit = nitpicking
>

Yeah I figured that much :)
I'm just used to seeing it along with a request.

> "happening" is mispelled
>

Fixed. Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-text_style-fix-overflow-in-vlc_html_color.patch
Type: text/x-patch
Size: 951 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180704/8f860900/attachment.bin>