[vlc-devel] [PATCH 1/4] vgl: provide a module to allow rendering in a user defined opengl context

[Rémi Denis-Courmont]

I vaguely recall arguing against abstraction breakage of GL some time ago. Maybe I recall wrong, or maybe it was about something else.

Le 4 juillet 2018 12:42:07 GMT+03:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>On Wed, Jul 4, 2018, at 11:25, Rémi Denis-Courmont wrote:
>> I objected to the union as well, so that's not an argument that I'd
>> receive.
>When did you object ? I don't see any replies when I proposed the patch
>to the mailing
>listhttps://mailman.videolan.org/pipermail/vlc-devel/2017-June/113751.html
>
>> 
>>  At least the current union breaks the abstraction unidirectionally.
>>  Not your patch, which breakd other GL provider users.> 
>> Le 4 juillet 2018 11:06:35 GMT+03:00, Pierre Lamot
>> <pierre at videolabs.io> a écrit :>>>  I don't really see why this needs
>to be exposed here. Virtualized
>>>>  plugins
>>>>>>>  generally call the initialization and deinitialization
>callbacks
>>>>  in-situ.
>>>>>> 
>>> 
>>> AFAIK, opengl modules don't have access to the picture size. 
>>> 
>>> 
>>> 
>>>>  In fact, it looks like breaking the existing abstraction.
>>> 
>>> 
>>> Isn't this union purpose to break abstraction and handle
>>> special cases?
>>>>> 
>>> 
>>> --
>>> 
>>> Pierre Lamot
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
>> 
>> --
>>  Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>>  excuser ma brièveté.>
>_________________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180704/8bc99eda/attachment.html>