[vlc-devel] [vlc-commits] dec: update pause/rate when the output is restarted

[Thomas Guillem]

On Wed, Jul 4, 2018, at 18:58, Rémi Denis-Courmont wrote:
> Le keskiviikkona 4. heinäkuuta 2018, 11.17.29 EEST Thomas Guillem a écrit :
> > I removed this commit with a push force, it's not good in the current state
> > because I need to make sure that aout/vout functions are called from the
> > DecoderThread and from the Vout in the sametime.
> 
> You mean you want to change the rate on all tracks at the same time? I can see 
> why you would ideally want that, but it sounds kinda impossible with decoders 
> running in their own threads.

No I didn't meant that, but I wrote a typo:

I need to make sure that aout/vout functions are *NOT* called from the
DecoderThread and from the Output callbacks at the same time.
Since the control var are protected with one lock, and the outputs with one other, this make it quite difficile.


> 
> And in any case, you cannot really control when exactly the audio output will 
> change rate.  Especially after audio_output_t.set_rate is added (WASAPI and 
> PA) to expedite rate change.

OK.

> 
> -- 
> レミ・デニ-クールモン
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel