[vlc-devel] [PATCH 0/9] Input Items duration cleaning

Rémi Denis-Courmont remi at remlab.net
Sat Jul 7 11:38:41 CEST 2018


Invalid should be changed to zero or unknown on case by case basis. I doubt that it's consistently used for zero duration - not that I'd have checked though.

Capture device duration is not zero, it's indeterminate AFAICT.

Le 7 juillet 2018 11:35:57 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>For now I actually used 3 defines (invalid, zero, unknown) which are 
>strictly equivalent to the values that where there before but with no 
>meanings to the values.
>
>
>I think invalid and zero should be merged because they had the same 
>value and an invalid duration doesn't make sense when we have zero and 
>unknown. But there might be cases where invalid actually meant unknown
>:'(
>
>
>On 2018-07-06 19:07, Rémi Denis-Courmont wrote:
>> Le perjantaina 6. heinäkuuta 2018, 16.01.26 EEST Steve Lhomme a écrit
>:
>>> Right now -1 and VLC_TICK_INVALID are used in the code. -1 seems to
>refer to
>>> items with no duration set at all (not particularly 0) and some are
>set
>>> VLC_TICK_INVALID which is actually 0 which is proper duration, at
>least
>>> it's not unknown/unset.
>> Oh yes please.
>>
>> Though I think card items diuration should be unknown, not zero.
>>
>> -- 
>> 雷米‧德尼-库尔蒙
>> http://www.remlab.net/
>>
>>
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180707/90cbc0ba/attachment.html>


More information about the vlc-devel mailing list