[vlc-devel] [PATCH v2 1/3] vgl: provide a module to allow rendering in a user defined opengl context

[Pierre Lamot]

> > --- a/modules/video_output/opengl/vout_helper.c
> > +++ b/modules/video_output/opengl/vout_helper.c
> > @@ -979,6 +979,7 @@ vout_display_opengl_t
> > *vout_display_opengl_New(video_format_t *fmt, }
> > 
> >      GL_ASSERT_NOERROR();
> > +
> >      return vgl;
> >  }
> > 
> 
> !?
> 

Oops, my bad

> > +static void Close(vlc_object_t *object)
> > +{
> > +    vlc_gl_t *gl = (vlc_gl_t *)object;
> > +    vout_display_sys_t *sys = gl->sys;
> > +    if (sys->cleanupCb)
> > +        sys->cleanupCb(sys->opaque);
> 
> What is the cleanup callback supposed to do? It seems unbalanced.

It's suppose to provide a mean for users to release resources they allocated for rendering (ie: texture allocation during resizes) once they are no longer required.
This might not be mandatory, but it felt nicer.

> > +            msg_Err( gl, varname " address is missing" );          \
> Nitpicking but %s would require fewer strings.

yes