[vlc-devel] [PATCH v2 1/3] vgl: provide a module to allow rendering in a user defined opengl context

[Rémi Denis-Courmont]

Le torstaina 12. heinäkuuta 2018, 19.31.52 EEST Pierre Lamot a écrit :
> > > +static void Close(vlc_object_t *object)
> > > +{
> > > +    vlc_gl_t *gl = (vlc_gl_t *)object;
> > > +    vout_display_sys_t *sys = gl->sys;
> > > +    if (sys->cleanupCb)
> > > +        sys->cleanupCb(sys->opaque);
> > 
> > What is the cleanup callback supposed to do? It seems unbalanced.
> 
> It's suppose to provide a mean for users to release resources they allocated
> for rendering (ie: texture allocation during resizes) once they are no
> longer required. This might not be mandatory, but it felt nicer.

The question is more about the imbalance than the role of cleanup.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/