[vlc-devel] [PATCH 3/9] demux: mkv: simplify block handling

Filip Roséen filip at atch.se
Mon Jul 16 12:05:49 CEST 2018


Thanks for reviewing.

On 2018-07-16 11:57, Steve Lhomme wrote:

> Although I said everything in libmatroska can be used, this class is not really supposed
> to be used, hence the name Internal.

In the future, do not use `public` inheritance in *libmatroska* for
said entities as that would have prevented people from using it the
way it is now.

> But in reality it should be but with a different name. So we can use it and will change
> the name when/if it does.

You don't need to rename it, one could argue that *"Internal"* means
the internal material of each block, where `KaxBlock` and
`KaxSimpleBlock` are wrappers around said internal material.

It might also be somewhat problematic renaming it now, unless you want
to break a lot of projects. I searched *github* for people using
`KaxInternalBlock`, and I am definitely not the first, and probably
not the last.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180716/95fa807b/attachment.html>

More information about the vlc-devel mailing list