[vlc-devel] [PATCH 1/3] libvlc: libvlc_MetadataRequest: add option for no automatic recursion

[Rémi Denis-Courmont]

Le vendredi 20 juillet 2018, 11:15:42 EEST Filip Roséen a écrit :
> The previous behavior of libvlc_MetadataRequest was introduced in
> f9aab1fe34, which resulted in unconditional recursion as the
> i_preparse_depth of the passed item would always reset back to 1.
> 
> In order to have explicit control over how far we preparse, a new
> option has been added simply stating: "do not automatically recurse,
> use the i_preparse_depth of the item passed".

That seems very unnatural to me, and is only likely to either perpetuate the 
problem (because people forget the flag), or trigger cargo-cult (because 
people copy the flag not figuring out why).

IMO, there are no valid reasons why recursion depth should be ignored. This 
was a bug.

-- 
Rémi Denis-Courmont