[vlc-devel] [PATCH 1/3] libvlc: libvlc_MetadataRequest: add option for no automatic recursion

[Filip Roséen]

Hi Rémi,

On 2018-07-21 08:22, Rémi Denis-Courmont wrote:

> That seems very unnatural to me, and is only likely to either perpetuate the 
> problem (because people forget the flag), or trigger cargo-cult (because 
> people copy the flag not figuring out why).
> 
> IMO, there are no valid reasons why recursion depth should be ignored. This 
> was a bug.

I definitely agree with you on the above, though I am afraid that this
bug has now slipped out in the open and people being people, I would
not be surprised if people actually depend on this behavior now.

It is possible to fix the issue by not changing the behavior of
`libvlc_MetadataRequest` at all, though it involves accessing the
*preparser* from the *libvlc object*, which to me is not ideal.

What do you think we can do about this? Input is much appreciated as I
really want this whole mess cleaned up.

Best Regards,\
Filip
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180721/a6755c87/attachment.html>