[vlc-devel] [PATCH] xdg_shell needs to be fully configured

[Rémi Denis-Courmont]

Le tiistaina 12. kesäkuuta 2018, 17.14.43 EEST erwan.tulou at gmail.com a écrit :
> Hello,
> 
>     One more (important) patch to improve xdg_shell.
> 
>     the Wayland documentation makes it explicit that no buffer must be
> attached or committed before an xdg surface is fully configured.
> (ack_configure sent).
>     Therefore, the xdg_shell vout window must ensure that the
> ack_configure() has been sent before handing over the surface handler to
> be used.
> 
>     On Weston, the bug is straightforward with the following message :
> error: xdg_surface at 9: error 3: xdg_surface has never been configured

It is true that VLC violates the letter of the protocol specification, but I 
cannot reproduce the problem with Weston 4.0.0.

In any case, it looks to me that the patch will lock-up the wl_shell plugin.

-- 
Rémi Denis-Courmont
http://www.remlab.net/