[vlc-devel] [PATCH] xdg_shell needs to be fully configured

[Rémi Denis-Courmont]

Le tiistaina 12. kesäkuuta 2018, 21.52.15 EEST erwan.tulou at gmail.com a écrit :
> On 12/06/2018 20:02, Rémi Denis-Courmont wrote:
> > Le tiistaina 12. kesäkuuta 2018, 17.14.43 EEST erwan.tulou at gmail.com a 
écrit :
> >> Hello,
> >> 
> >>      One more (important) patch to improve xdg_shell.
> >>      
> >>      the Wayland documentation makes it explicit that no buffer must be
> >> 
> >> attached or committed before an xdg surface is fully configured.
> >> (ack_configure sent).
> >> 
> >>      Therefore, the xdg_shell vout window must ensure that the
> >> 
> >> ack_configure() has been sent before handing over the surface handler to
> >> be used.
> > 
> > Well that is valid point. But where does it say that you can commit a
> > surface without a buffer to side step that requirement?
> 
> to side step ?  Do you mean to fulfill that requirement ?

Sure, it fulfills the XDG-shell requirement to wait for the surface to be 
configured before a buffer is attached. But in exchange, it fails the Wayland 
requirement for an attached buffer before a commit.

It is not clear to me that committing without a buffer is permitted by the 
baseline protocol.

-- 
Реми Дёни-Курмон
http://www.remlab.net/