[vlc-devel] [PATCH 2/2] vlc_block: store per block ancillary

Francois Cartegnie fcvlcdev at free.fr
Tue Jun 19 20:00:38 CEST 2018

Le 19/06/2018 à 19:41, Rémi Denis-Courmont a écrit :
> Le tiistaina 19. kesäkuuta 2018, 20.38.41 EEST Francois Cartegnie a écrit :
>> Le 19/06/2018 à 19:22, Rémi Denis-Courmont a écrit :
>>>>  /** Initial memory alignment of data block.
>>> This is out of place. Block_t is a generic data structure, not some demux/
>>> codec internal.
>> If that's generic, why does it stores nb of samples or timestamp ?
> Timestamp is pretty generic and grand fathered.
> Sample counts is grand fathered from the merger of aout_buffer_t, and could be 
> removed fairly easily if we wanted.

Not. Samples count is meaningful for opus at least.

As mentioned, the amount of code to transmit, manage and rebind sidedata
is huge. We can transmit it the simple way along with the referred data.

Francois Cartegnie
VideoLAN - VLC Developer

More information about the vlc-devel mailing list