[vlc-devel] [PATCH 2/2] vlc_block: store per block ancillary

[Rémi Denis-Courmont]

Le tiistaina 19. kesäkuuta 2018, 21.00.38 EEST Francois Cartegnie a écrit :
> Le 19/06/2018 à 19:41, Rémi Denis-Courmont a écrit :
> > Le tiistaina 19. kesäkuuta 2018, 20.38.41 EEST Francois Cartegnie a écrit 
:
> >> Le 19/06/2018 à 19:22, Rémi Denis-Courmont a écrit :
> >>>>  /** Initial memory alignment of data block.
> >>> 
> >>> This is out of place. Block_t is a generic data structure, not some
> >>> demux/
> >>> codec internal.
> >> 
> >> If that's generic, why does it stores nb of samples or timestamp ?
> > 
> > Timestamp is pretty generic and grand fathered.
> > 
> > Sample counts is grand fathered from the merger of aout_buffer_t, and
> > could be removed fairly easily if we wanted.
> 
> Not. Samples count is meaningful for opus at least.

aout_buffer_t was never meant to convey Opus and never did. Some people 
started reusing i_nb_samples for other purpose that what it was meant  for.

And that's a counter-example why I refuse to have purpose-specific fields in 
generic data structure.

-- 
レミ・デニ-クールモン
http://www.remlab.net/