[vlc-devel] [PATCH 2/2] vlc_block: store per block ancillary

[Francois Cartegnie]

Le 19/06/2018 à 20:06, Rémi Denis-Courmont a écrit :
> 
> aout_buffer_t was never meant to convey Opus and never did. Some people 
> started reusing i_nb_samples for other purpose that what it was meant  for.
> 
> And that's a counter-example why I refuse to have purpose-specific fields in 
> generic data structure.
> 

ancillary/sidedata has no specificity in any way. It is as generic as a
block. It can carry codec specific sample information, as well as frame
thumbnails from transcoding to muxers, and many other possible uses.

We already have many broken ways to pass data belonging or depending on
block boundary (p_description, metadata in esformat, ...). Creating new
channels just to extract forward reorder and rebind data over fifos,
esout, modules and others, when it just refers to the data block, is
just another bloat.

-- 
Francois Cartegnie
VideoLAN - VLC Developer