[vlc-devel] [PATCH v2 1/3] Introduce media source and media tree API

[Rémi Denis-Courmont]

Le samedi 23 juin 2018, 00:02:14 EEST Romain Vimont a écrit :
> On Fri, Jun 22, 2018 at 08:21:19PM +0100, Rémi Denis-Courmont wrote:
> > We already have an SD abstraction and so far I have not seen a
> > justification for replacing it.
> 
> If by SD abstraction, you mean vlc_services_discovery.h, it's still
> there (at least for now) without changes.
> 
> The purpose of these patches is to move SD out of the playlist. They
> move the part which stores the media detected by the SD and
> browsing/preparsing from the playlist to a separate component.

SD is *already* out of the playlist so that paragraph is very meaningless. The 
separation was done ages ago to use SD from LibVLC.

Input items and nodes are also separate from the playlist, since forever, or 
at least since the last playlist rewrite over a decade ago.

So that is all pretty meaningless.

> > Hence adding any new VLC object derivative seems wrong.
> 
> Currently, everything is child of the playlist object.

Input items and nodes do not have a parent to begin with, so they are 
definitely not children of the playlist object.

SD do not care what their parent is, and already now the abstraction is in 
place and in use to not have the playlist as parent.

> We would like
> independant components to be separated, so we need new VLC objects,
> childs of the libvlc object, siblings of the playlist. Don't we?

You already have that. SD is already an object. IE and IN must not be objects 
because there can be so many of them.

-- 
Rémi Denis-Courmont