[vlc-devel] [PATCH v2 1/3] Introduce media source and media tree API

[Romain Vimont]

On Tue, Jun 26, 2018 at 11:37:43AM +0300, Rémi Denis-Courmont wrote:
> Le samedi 23 juin 2018, 00:02:14 EEST Romain Vimont a écrit :
> > On Fri, Jun 22, 2018 at 08:21:19PM +0100, Rémi Denis-Courmont wrote:
> > > We already have an SD abstraction and so far I have not seen a
> > > justification for replacing it.
> > 
> > If by SD abstraction, you mean vlc_services_discovery.h, it's still
> > there (at least for now) without changes.
> > 
> > The purpose of these patches is to move SD out of the playlist. They
> > move the part which stores the media detected by the SD and
> > browsing/preparsing from the playlist to a separate component.
> 
> SD is *already* out of the playlist so that paragraph is very meaningless. The 
> separation was done ages ago to use SD from LibVLC.

My sentence was inaccurate: I meant "move SD-related stuff out of the
playlist".

Specifically:
 - struct playlist_private_t has a field "struct vlc_list sds"
 - playlist_ServicesDiscovery*() in playlist/services_discovery.c

> > We would like
> > independant components to be separated, so we need new VLC objects,
> > childs of the libvlc object, siblings of the playlist. Don't we?
> 
> You already have that. SD is already an object. IE and IN must not be objects 
> because there can be so many of them.

IE and IN?