[vlc-devel] [RFC PATCH 5/8] core: Expose input_CreatePreparser

Thomas Guillem thomas at gllm.fr
Tue Jun 26 13:13:35 CEST 2018


On Tue, Jun 26, 2018, at 13:10, Rémi Denis-Courmont wrote:
> Hi,
> 
>  I would expect that the ML subcomponent handling preparsing is common
>  core code, not per-plugin code though ... ?
The ML will be a module. We'll be able to build VLC/LIBVLC without it.

> 
> Le 26 juin 2018 09:54:19 GMT+01:00, Thomas Guillem <thomas at gllm.fr>
> a écrit :>> 
>> 
>> On Tue, Jun 26, 2018, at 10:26, Rémi Denis-Courmont wrote:
>> 
>>>  Le lundi 25 juin 2018, 11:10:03 EEST Hugo Beauzée-Luyssen a écrit :
>>>>>>>  ---
>>>> 
>>>>   include/vlc_input.h         | 14 ++++++++++++++
>>>> 
>>>>   src/input/input_interface.h | 13 -------------
>>>> 
>>>>   src/libvlccore.sym          |  1 +
>>>> 
>>>>   3 files changed, 15 insertions(+), 13 deletions(-)
>>>> 
>>>  
>>> 
>>>  Exposing the preparser out of the core sounds like a bad idea. That
>>>  makes it
>>>>>>  hard, if at all possible, for multiple interfaces to use the same
>>>  preparser.
>>>>>>  
>>> 
>>>  Plus that potentially means each interface has to reinvent the
>>>  preparser
>>>>>>  queuing and pacing, which is a big no no.
>>> 
>> 
>> 
>> I really think the medialibrary should use the input_thread_t
>> directly and not use the preparser helper since the medialibrary
>> already handle queuing and everything.
>>>> 
>> 
>> I don't see any problems about exposing this function.
>> 
>> 
>> 
>>>  
>>> 
>>>  -- 
>>> 
>>>  Rémi Denis-Courmont
>>> 
>>>  
>>> 
>>>  
>>> 
>>> 
>>> 
>>>  vlc-devel mailing list
>>> 
>>>  To unsubscribe or modify your subscription options:
>>> 
>>>  https://mailman.videolan.org/listinfo/vlc-devel
>>> 
>> 
>> 
>> vlc-devel mailing list
>> 
>> To unsubscribe or modify your subscription options:
>> 
>> https://mailman.videolan.org/listinfo/vlc-devel
>> 
> 
> --
>  Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>  excuser ma brièveté.> _________________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180626/32c915c1/attachment.html>


More information about the vlc-devel mailing list