[vlc-devel] [RFC PATCH 5/8] core: Expose input_CreatePreparser

[Rémi Denis-Courmont]

Hi,

I would expect that the ML subcomponent handling preparsing is common core code, not per-plugin code though ... ?

Le 26 juin 2018 09:54:19 GMT+01:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>
>On Tue, Jun 26, 2018, at 10:26, Rémi Denis-Courmont wrote:
>> Le lundi 25 juin 2018, 11:10:03 EEST Hugo Beauzée-Luyssen a écrit :
>> > ---
>> >  include/vlc_input.h         | 14 ++++++++++++++
>> >  src/input/input_interface.h | 13 -------------
>> >  src/libvlccore.sym          |  1 +
>> >  3 files changed, 15 insertions(+), 13 deletions(-)
>> 
>> Exposing the preparser out of the core sounds like a bad idea. That
>makes it 
>> hard, if at all possible, for multiple interfaces to use the same
>preparser.
>> 
>> Plus that potentially means each interface has to reinvent the
>preparser 
>> queuing and pacing, which is a big no no.
>
>I really think the medialibrary should use the input_thread_t directly
>and not use the preparser helper since the medialibrary already handle
>queuing and everything.
>
>I don't see any problems about exposing this function.
>
>> 
>> -- 
>> Rémi Denis-Courmont
>> 
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180626/e439da82/attachment.html>