[vlc-devel] [PATCH 2/2] vlc_block: store per block ancillary

Francois Cartegnie fcvlcdev at free.fr
Tue Jun 26 13:51:33 CEST 2018


Le 26/06/2018 à 13:36, Rémi Denis-Courmont a écrit :
> Adding a non-immediate field is simpler if you ignore all the bugs that it potentially introduces silently. But that is not a sane thing to do.
> 
> Everytime somebody else tries to change a common compound type in potentially dangerous ways (es_format_t multiple times) you rightfully raise concerns. Same thing here.
> 
> Besides, I don't agree that adding a new control or callback is difficult. It requires no changes in most cases, where the side data is not used or not expected.

If you ignore buffering locations, fifo, asynchronous decoders, es_out
proxying, flow routing/duplication, and some others yes...

-- 
Francois Cartegnie
VideoLAN - VLC Developer


More information about the vlc-devel mailing list