[vlc-devel] [PATCH 2/2] vlc_block: store per block ancillary

Rémi Denis-Courmont remi at remlab.net
Tue Jun 26 18:15:27 CEST 2018

You cannot ignore any of those things. Your patch does and that's a bug.

Le 26 juin 2018 12:51:33 GMT+01:00, Francois Cartegnie <fcvlcdev at free.fr> a écrit :
>Le 26/06/2018 à 13:36, Rémi Denis-Courmont a écrit :
>> Adding a non-immediate field is simpler if you ignore all the bugs
>that it potentially introduces silently. But that is not a sane thing
>to do.
>> Everytime somebody else tries to change a common compound type in
>potentially dangerous ways (es_format_t multiple times) you rightfully
>raise concerns. Same thing here.
>> Besides, I don't agree that adding a new control or callback is
>difficult. It requires no changes in most cases, where the side data is
>not used or not expected.
>If you ignore buffering locations, fifo, asynchronous decoders, es_out
>proxying, flow routing/duplication, and some others yes...
>Francois Cartegnie
>VideoLAN - VLC Developer
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:

Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180626/e8a3cf2e/attachment.html>

More information about the vlc-devel mailing list