[vlc-devel] [PATCH 4/4] intromsg: Ensure non-ascii characters are properly displayed on win32

Rémi Denis-Courmont remi at remlab.net
Tue Mar 13 22:06:57 CET 2018

Le tiistaina 13. maaliskuuta 2018, 18.17.45 EET Hugo Beauzée-Luyssen a écrit :
> On Mon, Mar 12, 2018, at 9:58 PM, Rémi Denis-Courmont wrote:
> > I cannot see a rationale for moving away from the message log,
> As described in the mentioned ticket, msg_* doesn't play well with non-ascii
> character when printing on a windows console

That is not an argument for making a special case of one group out of 
thousands of VLC log calls.

> >  and if piping is supported, this patch will presumably break it.
> I can't say I tested this, but I'm a bit ensure why this patch would break
> this?

Obivously, it corrupts the pipe content, unlike the VLC logs.


More information about the vlc-devel mailing list