[vlc-devel] [PATCH 4/4] intromsg: Ensure non-ascii characters are properly displayed on win32

[Hugo Beauzée-Luyssen]

On Tue, Mar 13, 2018, at 10:06 PM, Rémi Denis-Courmont wrote:
> Le tiistaina 13. maaliskuuta 2018, 18.17.45 EET Hugo Beauzée-Luyssen a écrit :
> > On Mon, Mar 12, 2018, at 9:58 PM, Rémi Denis-Courmont wrote:
> > > I cannot see a rationale for moving away from the message log,
> > 
> > As described in the mentioned ticket, msg_* doesn't play well with non-ascii
> > character when printing on a windows console
> 
> That is not an argument for making a special case of one group out of 
> thousands of VLC log calls.
> 

The intro message is currently the exception as far as I can see. Everything in rc/oldrc is sent back to the user through msg_rc instead of msg_Info/Warn/Err

> > >  and if piping is supported, this patch will presumably break it.
> > 
> > I can't say I tested this, but I'm a bit ensure why this patch would break
> > this?
> 
> Obivously, it corrupts the pipe content, unlike the VLC logs.
> 

I'm not saying it doesn't, but I'm saying it's not obvious to me.

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr