[vlc-devel] [PATCH] Fixed #19993: Made toolTips on Full Screen consistent

[Marvin Scholz]

On 19 Mar 2018, at 13:20, Thomas Guillem wrote:

> Hello,
>
> Just one comment about your commit title/message:
> - You should mention that it's a macos patch by prefixing your title
>   with "macos: "- You should use the imperative form: Made => Make

"macosx" please, as we agreed to use that for all macOS stuff regardless 
of the
new OS name being macOS.

> - Mention the track ticket in the commit message (and not the title)
>   like "Fixes #19993"
> cf.
> https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
> On Mon, Mar 19, 2018, at 12:02, Daksh Shah wrote:
>> Now the tooltips which are shown in the Normal View are same as the
>> ones which are shown in Full-Screen View. Adapted the shorter 
>> version.> And also, changed the Normal View toolTip of "Fullscreen" 
>> to "Enter
>> fullscreen">
>> _________________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>> Email had 1 attachment:
>
>
>>  * 0001-Fixed-19993-Made-toolTips-on-Full-Screen-consistent.patch 5k
>>    (text/plain)
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel